fix(transient): cancel transient newlines as with primary newlines#7595
Merged
JanDeDobbeleer merged 1 commit intoJun 23, 2026
Merged
Conversation
Currently, if a prompt has `newline` set to `true`, the newline will be omitted in several sensible cases. However this behaviour isn't followed if `transient_prompt` has `newline` set to `true`, meaning the positioning of the transient prompt relative to the primary one differs depending on whether the cancellation criteria are met and the primary prompt has had its newline removed. This patch makes sure that both prompt types use the same cancellation logic.
JanDeDobbeleer
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Currently, if a prompt has
newlineset totrue, the newline will be omitted in several sensible cases. However this behaviour isn't followed iftransient_prompthasnewlineset totrue, meaning the positioning of the transient prompt relative to the primary one differs depending on whether the cancellation criteria are met and the primary prompt has had its newline removed.This PR makes sure that both prompt types use the same cancellation logic.
NB: this PR is a re-submission of #7577 as per @JanDeDobbeleer's suggestion.